[
https://issues.apache.org/jira/browse/ZOOKEEPER-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188997#comment-13188997
]
Hadoop QA commented on ZOOKEEPER-1365:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12511078/ZOOKEEPER-1365.patch
against trunk revision 1231809.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/911//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/911//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/911//console
This message is automatically generated.
> Removing a duplicate function and another minor cleanup in QuorumPeer.java
> --------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1365
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1365
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Priority: Trivial
> Attachments: ZOOKEEPER-1365.patch, ZOOKEEPER-1365.patch
>
>
> - getMyId() and getId() in QuorumPeer are doing the same thing
> - QuorumPeer.quorumPeers is being read directly from outside QuorumPeer,
> although we have the getter QuorumPeers.getView().
> The purpose of this cleanup is to later be able to change more easily the way
> QuorumPeer manages its list of peers (to support dynamic changes in this
> list).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
