[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13191623#comment-13191623
 ] 

Patrick Hunt commented on ZOOKEEPER-1309:
-----------------------------------------

No. That was my point earlier about how this is just kluged together (if 
someone wants to help on this lmk). The bot uses the last patch you attached to 
the jira and applies it to trunk regardless of any other setting.
                
> Creating a new ZooKeeper client can leak file handles
> -----------------------------------------------------
>
>                 Key: ZOOKEEPER-1309
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1309
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: java client
>    Affects Versions: 3.3.4
>            Reporter: Daniel Lord
>            Assignee: Daniel Lord
>            Priority: Critical
>             Fix For: 3.4.3, 3.5.0
>
>         Attachments: zk-1309-1.patch, zk-1309-1.patch, zk-1309-1.patch, 
> zk-1309-3.patch
>
>
> If there is an IOException thrown by the constructor of ClientCnxn then file 
> handles are leaked because of the initialization of the Selector which is 
> never closed.
>     final Selector selector = Selector.open();
> If there is an abnormal exit from the constructor then the Selector is not 
> closed and file handles are leaked.  You can easily see this by setting the 
> hosts string to garbage ("qwerty", "asdf", etc.) and then try to open a new 
> ZooKeeper connection.  I've observed the same behavior in production when 
> there were DNS issues where the host names of the ensemble can no longer be 
> resolved and the application servers quickly run out of handles attempting to 
> (re)connect to zookeeper.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to