-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3662/
-----------------------------------------------------------

Review request for bookkeeper.


Summary
-------

If a client remains connected to a bookie, requests do not timeout. This is an 
undesirable behavior if a bookie is up but not responding to a request for some 
reason, like it is slow or has not handled an exception appropriately and did 
not respond to the client. I propose to add a timeout mechanism.


This addresses bug BOOKKEEPER-23.
    https://issues.apache.org/jira/browse/BOOKKEEPER-23


Diffs
-----

  bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java 
cb3bb26 
  
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ClientConfiguration.java
 5e1c964 
  
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/NIOServerFactory.java
 2a8df38 
  
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
 2fa79bb 
  
bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestReadTimeout.java
 PRE-CREATION 
  bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BaseTestCase.java 
7403604 

Diff: https://reviews.apache.org/r/3662/diff


Testing
-------


Thanks,

Ivan

Reply via email to