[ https://issues.apache.org/jira/browse/ZOOKEEPER-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13201142#comment-13201142 ]
Hadoop QA commented on ZOOKEEPER-1374: -------------------------------------- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12512216/ZOOKEEPER-1374.patch against trunk revision 1240905. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/948//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/948//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/948//console This message is automatically generated. > C client multi-threaded test suite fails to compile on ARM architectures. > ------------------------------------------------------------------------- > > Key: ZOOKEEPER-1374 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1374 > Project: ZooKeeper > Issue Type: Bug > Components: c client > Affects Versions: 3.3.4 > Environment: Ubuntu 12.04 (precise) armel or armhf > Reporter: James Page > Assignee: James Page > Priority: Minor > Fix For: 3.4.3, 3.5.0 > > Attachments: ZOOKEEPER-1374.patch, ZOOKEEPER-1374.patch > > > The multi-threaded test suite fails to build on ARM architectures: > g++ -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated > -D_FORTIFY_SOURCE=2 -DUSE_STATIC_LIB -DTHREADED > -DZKSERVER_CMD="\"./tests/zkServer.sh\"" -Wall -g -MT > zktest_mt-ThreadingUtil.o -MD -MP -MF .deps/zktest_mt-ThreadingUtil.Tpo -c -o > zktest_mt-ThreadingUtil.o `test -f 'tests/ThreadingUtil.cc' || echo > './'`tests/ThreadingUtil.cc > /tmp/ccqJWQRC.s: Assembler messages: > /tmp/ccqJWQRC.s:373: Error: bad instruction `lock xaddl r4,[r3,#0]' > /tmp/ccqJWQRC.s:425: Error: bad instruction `lock xchgl r4,[r3,#0]' > gcc does provide alternative primitives (_sync_*) which provide better cross > platform compatibility; but that does make the assumption that a) gcc is > being used or b) the primitives are provided by alternative compilers. > Tracked in Ubuntu here: > https://bugs.launchpad.net/ubuntu/+source/zookeeper/+bug/920871 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira