[ https://issues.apache.org/jira/browse/ZOOKEEPER-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205508#comment-13205508 ]
Camille Fournier commented on ZOOKEEPER-1390: --------------------------------------------- Do you think we might want to leave in those more descriptive debug strings but guarded by an if (LOG.isDebugEnabled())? I don't care either way but it might be useful. Otherwise this looks good to me, good catch. > some expensive debug code not protected by a check for debug > ------------------------------------------------------------ > > Key: ZOOKEEPER-1390 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1390 > Project: ZooKeeper > Issue Type: Improvement > Components: server > Reporter: Benjamin Reed > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1390.patch > > > there is some expensive debug code in DataTree.processTxn() that formats > transactions for debugging that are very expensive but are only used when > errors happen and when debugging is turned on. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira