[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231776#comment-13231776
 ] 

Patrick Hunt commented on ZOOKEEPER-271:
----------------------------------------

Nice job! I'm reviewing now. Question though:

{noformat}
The options for some commands were changed to match the option usage in 
commons-cli.
But to maintain the compatibility the old argument style for these commands was 
preserved. This could be removed in a future revision.
{noformat}

does this mean the new client is 100% backward compatible with the old client 
or not? If not we should mark this as an incompatible change (there's a flag 
for this) and document in the "release notes".
                
> Better command line parsing in ZookeeperMain.
> ---------------------------------------------
>
>                 Key: ZOOKEEPER-271
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-271
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: java client
>    Affects Versions: 3.0.0, 3.0.1
>            Reporter: Mahadev konar
>            Assignee: Hartmut Lang
>            Priority: Minor
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-271-1.patch, ZOOKEEPER-271.patch
>
>
> The command line parsing in zookeepermain is very basic.We should use some 
> kind of cli parsing (commons-cli?) or something else that is standard and 
> improve our command line parsing. This will remove the scattered code that we 
> have in zookeepermain and we will have much better command line parsing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to