[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13241972#comment-13241972
 ] 

Henry Robinson commented on ZOOKEEPER-1435:
-------------------------------------------

+1 looks good to me, I'll commit shortly. 
                
> cap space usage of default log4j rolling policy
> -----------------------------------------------
>
>                 Key: ZOOKEEPER-1435
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1435
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: scripts
>    Affects Versions: 3.4.3, 3.3.5, 3.5.0
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1435.patch
>
>
> Our current log4j log rolling policy (for ROLLINGFILE) doesn't cap the max 
> logging space used. This can be a problem in production systems. See similar 
> improvements recently made in hadoop: HADOOP-8149
> For ROLLINGFILE only, I believe we should change the default threshold to 
> INFO and cap the max space to something reasonable, say 5g (max file size of 
> 256mb, max file count of 20). These will be the defaults in log4j.properties, 
> which you would also be able to override from the command line.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to