----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4729/ -----------------------------------------------------------
(Updated 2012-04-19 16:01:55.574362) Review request for zookeeper. Changes ------- updated patch following Flavio's comments Summary ------- https://issues.apache.org/jira/browse/ZOOKEEPER-1411 Currently every server has a different configuration file. With this patch, we will have all cluster membership definitions in a single file, and every sever can have a copy of this file. Diffs (updated) ----- /src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java 1327937 /src/java/main/org/apache/zookeeper/server/quorum/Leader.java 1327937 /src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java 1327937 /src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java 1327937 /src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 1327937 /src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java 1327937 /src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java 1327937 /src/java/main/org/apache/zookeeper/server/quorum/QuorumZooKeeperServer.java 1327937 /src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumHierarchical.java 1327937 /src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumMaj.java 1327937 /src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumVerifier.java 1327937 /src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java 1327937 /src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java 1327937 /src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java 1327937 /src/java/test/org/apache/zookeeper/server/util/DynamicConfigBCTest.java PRE-CREATION /src/java/test/org/apache/zookeeper/test/CnxManagerTest.java 1327937 /src/java/test/org/apache/zookeeper/test/FLETest.java 1327937 /src/java/test/org/apache/zookeeper/test/FLEZeroWeightTest.java 1327937 /src/java/test/org/apache/zookeeper/test/HierarchicalQuorumTest.java 1327937 /src/java/test/org/apache/zookeeper/test/LENonTerminateTest.java 1327937 /src/java/test/org/apache/zookeeper/test/ObserverTest.java 1327937 /src/java/test/org/apache/zookeeper/test/QuorumBase.java 1327937 /src/java/test/org/apache/zookeeper/test/QuorumUtil.java 1327937 /src/java/test/org/apache/zookeeper/test/StandaloneTest.java 1327937 Diff: https://reviews.apache.org/r/4729/diff Testing ------- Many tests were updated to work with the new configuration format. MembershipBCTest.java tests backward compatibility. Thanks, Alexander
