[
https://issues.apache.org/jira/browse/ZOOKEEPER-1167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269246#comment-13269246
]
Hadoop QA commented on ZOOKEEPER-1167:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12525778/ZOOKEEPER-1167.patch
against trunk revision 1334548.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1061//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1061//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1061//console
This message is automatically generated.
> C api lacks synchronous version of sync() call.
> -----------------------------------------------
>
> Key: ZOOKEEPER-1167
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1167
> Project: ZooKeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.3, 3.4.3, 3.5.0
> Reporter: Nicholas Harteau
> Fix For: 3.4.3, 3.5.0
>
> Attachments: ZOOKEEPER-1167.patch
>
>
> Reading through the source, the C API implements zoo_async() which is the
> zookeeper sync() method implemented in the multithreaded/asynchronous C API.
> It doesn't implement anything equivalent in the non-multithreaded API.
> I'm not sure if this was oversight or intentional, but it means that the
> non-multithreaded API can't guarantee consistent client views on critical
> reads.
> The zkperl bindings depend on the synchronous, non-multithreaded API so also
> can't call sync() currently.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
