[
https://issues.apache.org/jira/browse/ZOOKEEPER-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13282822#comment-13282822
]
Patrick Hunt commented on ZOOKEEPER-1437:
-----------------------------------------
Sorry Eugene but I think I'm making a hash of explaining myself to you.
queuePacket needs to be a non-blocking call. This latest patch makes it
potentially blocking and that will likely break some things for end users.
see my earlier comment:
bq. I'm wondering why approach it this way rather than checking if we are in
the auth phase in "doIO" and then only sending auth packets until the auth
phase has been finalized. (leave any non-auth packets in the queue)
I think what we should be doing is queuing regular the packets as usual,
however the "doIO" thread will not forward these packets to the server until
the SASL auth phase is completed. SASL packets on the other hand should not be
queued but generated on the fly based on the connection state (generated in
doIO based on this state) Your patch from May 7 was pretty close - except for
the issues I raised on May 9.
Do you see my point wrt this earlier feedback? If not please lmk and I'll try
to clarify specific points.
> Client uses session before SASL authentication complete
> -------------------------------------------------------
>
> Key: ZOOKEEPER-1437
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1437
> Project: ZooKeeper
> Issue Type: Bug
> Components: java client
> Affects Versions: 3.4.3
> Reporter: Thomas Weise
> Assignee: Eugene Koontz
> Fix For: 3.4.4, 3.5.0
>
> Attachments: ZOOKEEPER-1437.patch, ZOOKEEPER-1437.patch,
> ZOOKEEPER-1437.patch, ZOOKEEPER-1437.patch, ZOOKEEPER-1437.patch,
> ZOOKEEPER-1437.patch, ZOOKEEPER-1437.patch, ZOOKEEPER-1437.patch,
> ZOOKEEPER-1437.patch, ZOOKEEPER-1437.patch
>
>
> Found issue in the context of hbase region server startup, but can be
> reproduced w/ zkCli alone.
> getData may occur prior to SaslAuthenticated and fail with NoAuth. This is
> not expected behavior when the client is configured to use SASL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
