[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396520#comment-13396520
 ] 

Hadoop QA commented on ZOOKEEPER-1490:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12532506/ZOOKEEPER_1490.patch
  against trunk revision 1351541.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1098//console

This message is automatically generated.
                
>  If the configured log directory does not exist zookeeper will not start. 
> Better to create the directory and start
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1490
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1490
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: scripts
>            Reporter: suja s
>            Priority: Minor
>         Attachments: ZOOKEEPER_1490.patch
>
>
> if the configured log directory does not exists zookeeper will not start. 
> Better to create the directory and start
> in zkEnv.sh we can change as follows
> if [ "x${ZOO_LOG_DIR}" = "x" ]
> then
>     ZOO_LOG_DIR="."
>    else
>     if [ ! -w "$ZOO_LOG_DIR" ] ; then
>         mkdir -p "$ZOO_LOG_DIR"
>     fi
> fi
>  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to