[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407368#comment-13407368
 ] 

Hadoop QA commented on ZOOKEEPER-1503:
--------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12535236/ZOOKEEPER-1503.patch
  against trunk revision 1357711.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1123//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1123//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1123//console

This message is automatically generated.
                
> remove redundant SASL configuration code in SaslAuthTest and SaslAuthFailTest
> -----------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1503
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1503
>             Project: ZooKeeper
>          Issue Type: Improvement
>         Environment: In SaslAuthTest and SaslAuthFail test, we set the JAAS 
> configuration twice with the same text string. This is confusing and 
> redundant, since we need only set it once.
>            Reporter: Eugene Koontz
>            Assignee: Eugene Koontz
>         Attachments: ZOOKEEPER-1503.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to