[
https://issues.apache.org/jira/browse/ZOOKEEPER-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443564#comment-13443564
]
Hadoop QA commented on ZOOKEEPER-1497:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12538966/ZOOKEEPER-1497-v5.patch
against trunk revision 1378285.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 9 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1172//console
This message is automatically generated.
> Allow server-side SASL login with JAAS configuration to be programmatically
> set (rather than only by reading JAAS configuration file)
> -------------------------------------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1497
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1497
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.4.3, 3.5.0
> Reporter: Matteo Bertozzi
> Assignee: Matteo Bertozzi
> Labels: security
> Fix For: 3.4.4, 3.5.0
>
> Attachments: ZOOKEEPER-1497-v1.patch, ZOOKEEPER-1497-v2.patch,
> ZOOKEEPER-1497-v3.patch, ZOOKEEPER-1497-v4.patch, ZOOKEEPER-1497-v5.patch
>
>
> Currently the CnxnFactory checks for "java.security.auth.login.config" to
> decide whether or not enable SASL.
> * zookeeper/server/NIOServerCnxnFactory.java
> * zookeeper/server/NettyServerCnxnFactory.java
> ** configure() checks for "java.security.auth.login.config"
> *** If present start the new Login("Server", SaslServerCallbackHandler(conf))
> But since the SaslServerCallbackHandler does the right thing just checking if
> getAppConfigurationEntry() is empty, we can allow SASL with JAAS
> configuration to be programmatically just checking weather or not a
> configuration entry is present instead of "java.security.auth.login.config".
> (Something quite similar was done for the SaslClient in ZOOKEEPER-1373)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
