[ https://issues.apache.org/jira/browse/ZOOKEEPER-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-1478: ------------------------------------- Affects Version/s: 3.4.3 > Small bug in QuorumTest.testFollowersStartAfterLeader( ) > -------------------------------------------------------- > > Key: ZOOKEEPER-1478 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1478 > Project: ZooKeeper > Issue Type: Bug > Components: tests > Affects Versions: 3.4.3 > Reporter: Alexander Shraer > Assignee: Alexander Shraer > Priority: Minor > Fix For: 3.4.4, 3.5.0 > > Attachments: ZOOKEEPER-1478.patch, ZOOKEEPER-1478.patch, > ZOOKEEPER-1478.patch, ZOOKEEPER-1478.patch > > > The following code appears in QuorumTest.testFollowersStartAfterLeader( ): > for (int i = 0; i < 30; i++) { > try { > zk.create("/test", "test".getBytes(), ZooDefs.Ids.OPEN_ACL_UNSAFE, > CreateMode.PERSISTENT); > break; > } catch(KeeperException.ConnectionLossException e) { > Thread.sleep(1000); > } > // test fails if we still can't connect to the quorum after 30 seconds. > Assert.fail("client could not connect to reestablished quorum: giving up > after 30+ seconds."); > } > From the comment it looks like the intention was to try to reconnect 30 times > and only then trigger the Assert, but that's not what this does. > After we fail to connect once and Thread.sleep is executed, Assert.fail will > be executed without retrying create. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira