[
https://issues.apache.org/jira/browse/ZOOKEEPER-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445300#comment-13445300
]
Eugene Koontz commented on ZOOKEEPER-1437:
------------------------------------------
Hi Rakesh,
Sorry to take a long time to respond to you. I'll try to be more prompt
especially as folks are hoping to get this in a release soon.
I see what you are asking: should we retry if there's a network error
connecting to the client (in your terms, a partition)?
I guess we could add some retry logic - something like:
{code}
while (!(saslClient.isComplete()) {
try {
sendSaslPacket(saslToken, cnxn); // throws SaslException, IOException
} catch (IOException ne) {
// transitory network failure: keep trying to reach server
} catch (SaslException se) {
// auth failed: nothing more we can do.
break;
}
}
{code}
Is that what you had in mind?
I think it would be good to test the SASL exchange in the presence of network
failures - I'm wondering what support there is already in Zookeeper tests for
network failure and if so, can we use them to test the SASL exchange.
> Client uses session before SASL authentication complete
> -------------------------------------------------------
>
> Key: ZOOKEEPER-1437
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1437
> Project: ZooKeeper
> Issue Type: Bug
> Components: java client
> Affects Versions: 3.4.3
> Reporter: Thomas Weise
> Assignee: Eugene Koontz
> Fix For: 3.4.4, 3.5.0
>
> Attachments: getXidCallHierarchy.png, ZOOKEEPER-1437.patch,
> ZOOKEEPER-1437.patch, ZOOKEEPER-1437.patch, ZOOKEEPER-1437.patch,
> ZOOKEEPER-1437.patch, ZOOKEEPER-1437.patch, ZOOKEEPER-1437.patch,
> ZOOKEEPER-1437.patch, ZOOKEEPER-1437.patch, ZOOKEEPER-1437.patch,
> ZOOKEEPER-1437.patch, ZOOKEEPER-1437.patch, ZOOKEEPER-1437.patch,
> ZOOKEEPER-1437.patch, ZOOKEEPER-1437.patch
>
>
> Found issue in the context of hbase region server startup, but can be
> reproduced w/ zkCli alone.
> getData may occur prior to SaslAuthenticated and fail with NoAuth. This is
> not expected behavior when the client is configured to use SASL.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
