[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467213#comment-13467213
 ] 

Flavio Junqueira commented on ZOOKEEPER-1551:
---------------------------------------------

I'd like to ask a couple of quick clarifications about this patch if you don't 
mind:

# Given that in Learner both follower and observer need to commit transactions 
after the snapshot, do we really need different code for follower and observer? 
# Observers also need to receive outstanding proposals, since commits do not 
have the proposals themselves, so I was wondering if the last optimization 
introduced in Leader is actually correct.

Thanks! 
                
> Observer ignore txns that comes after snapshot and UPTODATE 
> ------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1551
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1551
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.4.3
>            Reporter: Thawan Kooburat
>            Assignee: Thawan Kooburat
>            Priority: Critical
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1551.patch
>
>
> In Learner.java, txns which comes after the learner has taken the snapshot 
> (after NEWLEADER packet) are stored in packetsNotCommitted. The follower has 
> special logic to apply these txns at the end of syncWithLeader() method. 
> However, the observer will ignore these txns completely, causing data 
> inconsistency. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to