[
https://issues.apache.org/jira/browse/ZOOKEEPER-753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467260#comment-13467260
]
Hadoop QA commented on ZOOKEEPER-753:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12547293/ZOOKEEPER-753.patch
against trunk revision 1391526.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 patch. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1203//console
This message is automatically generated.
> log4j dependency in the pom needs to have exclusion lists
> ---------------------------------------------------------
>
> Key: ZOOKEEPER-753
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-753
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.4.5
> Reporter: Karthik K
> Labels: ivy
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-753.patch
>
>
> http://repo2.maven.org/maven2/org/apache/hadoop/zookeeper/3.3.0/zookeeper-3.3.0.pom
>
> The pom contains log4j dependency as itself.
> <dependency>
> <groupId>log4j</groupId>
> <artifactId>log4j</artifactId>
> <version>1.2.15</version>
> <scope>compile</scope>
> </dependency>
> This is broken without an exclusion list, since the pending dependencies of
> javax.mail. etc. are not necessary for the most part.
> Please fix this along with 3.3.1 and republish new dependencies , since at
> its current state , it is usable by some projects (to host in central , say).
> Correct dependency for log4j:
> <dependency>
> <groupId>log4j</groupId>
> <artifactId>log4j</artifactId>
> <version>1.2.15</version>
> <scope>compile</scope>
> <exclusions>
> <exclusion>
> <groupId>javax.mail</groupId>
> <artifactId>mail</artifactId>
> </exclusion>
> <exclusion>
> <groupId>javax.jms</groupId>
> <artifactId>jms</artifactId>
> </exclusion>
> <exclusion>
> <groupId>com.sun.jdmk</groupId>
> <artifactId>jmxtools</artifactId>
> </exclusion>
> <exclusion>
> <groupId>com.sun.jmx</groupId>
> <artifactId>jmxri</artifactId>
> </exclusion>
> </exclusions>
> </dependency>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
