[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473429#comment-13473429
 ] 

Alexander Shraer commented on ZOOKEEPER-107:
--------------------------------------------

Hi Jacky, 

great catch! it does seem that it would be better to first try to send the 
packet and only if
it was completely sent to remove it from the outgoingQueue. I wonder if we 
should also throw an
exception if pbb.hasRemaining() ? 

> Should we open a new jira for this?

that would be great, thanks!

Do the reconfiguration tests pass for you when this bug is solved ? I wonder 
why 
of all tests the reconfiguration tests were the ones hitting this bug... maybe 
because of 
the many leader/follower shutdowns that they do, not sure.

Thanks,
Alex



                
> Allow dynamic changes to server cluster membership
> --------------------------------------------------
>
>                 Key: ZOOKEEPER-107
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-107
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server
>            Reporter: Patrick Hunt
>            Assignee: Alexander Shraer
>             Fix For: 3.5.0
>
>         Attachments: SimpleAddition.rtf, zkreconfig-usenixatc-final.pdf, 
> ZOOKEEPER-107-1-Mar.patch, ZOOKEEPER-107-20-July.patch, 
> ZOOKEEPER-107-21-July.patch, ZOOKEEPER-107-22-Apr.patch, 
> ZOOKEEPER-107-23-SEP.patch, ZOOKEEPER-107-28-Feb.patch, 
> ZOOKEEPER-107-28-Feb.patch, ZOOKEEPER-107-29-Feb.patch, 
> ZOOKEEPER-107-3-Oct.patch, ZOOKEEPER-107-Aug-20.patch, 
> ZOOKEEPER-107-Aug-20-ver1.patch, ZOOKEEPER-107-Aug-25.patch, 
> zookeeper-3.4.0.jar, zookeeper-dev-fatjar.jar, 
> zookeeper-reconfig-sep11.patch, zookeeper-reconfig-sep12.patch, 
> zoo_replicated1.cfg, zoo_replicated1.members
>
>
> Currently cluster membership is statically defined, adding/removing hosts 
> to/from the server cluster dynamically needs to be supported.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to