> On Nov. 28, 2012, 6:19 p.m., Patrick Hunt wrote: > > src/java/main/org/apache/zookeeper/server/DataTree.java, line 1216 > > <https://reviews.apache.org/r/8094/diff/1/?file=190874#file190874line1216> > > > > this doesn't need synchronization?
I should be synchronizing and copying the HashSet values of the ephemerals map, yes. I'll fix this. > On Nov. 28, 2012, 6:19 p.m., Patrick Hunt wrote: > > src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java, line 111 > > <https://reviews.apache.org/r/8094/diff/1/?file=190885#file190885line111> > > > > This needs to be configurable from the get go. I'll add configuration options for the base URL, port, anything else I can think of. > On Nov. 28, 2012, 6:19 p.m., Patrick Hunt wrote: > > src/java/main/org/apache/zookeeper/server/admin/AdminServer.java, line 98 > > <https://reviews.apache.org/r/8094/diff/1/?file=190887#file190887line98> > > > > Even if we only support json initially, we should allow for other > > output formats to be supported eventually. Does this assumption limit us in > > any way going forward? i.e. is it ok to assume json output? Or should the > > user be somehow specifying this? In the next code review I'm going to add support for text (i.e. the original) output, as well as specifying the output format. - Skye ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8094/#review13824 ----------------------------------------------------------- On Nov. 16, 2012, 11:25 p.m., Skye Wanderman-Milne wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8094/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2012, 11:25 p.m.) > > > Review request for zookeeper, Patrick Hunt, Camille Fournier, and Henry > Robinson. > > > Description > ------- > > See my comment in ZOOKEEPER-1346. > > > This addresses bug ZOOKEEPER-1346. > https://issues.apache.org/jira/browse/ZOOKEEPER-1346 > > > Diffs > ----- > > ivy.xml fadf4f4 > src/java/main/org/apache/zookeeper/server/DataTree.java 0bb2317 > src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java 8b4c46b > src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java > eec2f2a > src/java/main/org/apache/zookeeper/server/ServerCnxn.java 6dd509b > src/java/main/org/apache/zookeeper/server/ServerCnxnFactory.java e5c6565 > src/java/main/org/apache/zookeeper/server/ServerStats.java aa0d93f > src/java/main/org/apache/zookeeper/server/SessionTracker.java 3535e1b > src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java 31f2785 > src/java/main/org/apache/zookeeper/server/WatchManager.java 0e7c815 > src/java/main/org/apache/zookeeper/server/ZKDatabase.java d6c0c05 > src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 7bb7b2f > src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java 369e621 > src/java/main/org/apache/zookeeper/server/ZooTrace.java ac14fe2 > src/java/main/org/apache/zookeeper/server/admin/AdminServer.java > PRE-CREATION > src/java/main/org/apache/zookeeper/server/admin/Command.java PRE-CREATION > src/java/main/org/apache/zookeeper/server/admin/CommandBase.java > PRE-CREATION > src/java/main/org/apache/zookeeper/server/admin/CommandOutputter.java > PRE-CREATION > src/java/main/org/apache/zookeeper/server/admin/Commands.java PRE-CREATION > src/java/main/org/apache/zookeeper/server/admin/JsonOutputter.java > PRE-CREATION > src/java/main/org/apache/zookeeper/server/quorum/LearnerSessionTracker.java > 3182419 > src/java/test/org/apache/zookeeper/server/PrepRequestProcessorTest.java > 8665bac > src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java 42207e1 > > Diff: https://reviews.apache.org/r/8094/diff/ > > > Testing > ------- > > unit tests > > Ran in standalone mode (only option right now) and manually tried out all the > commands/links > > > Thanks, > > Skye Wanderman-Milne > >