[ https://issues.apache.org/jira/browse/ZOOKEEPER-1574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528103#comment-13528103 ]
Raja Aluri commented on ZOOKEEPER-1574: --------------------------------------- Regarding the history if you are using git, blame -w should filter these changes and should still give you the correct author. I think we should fix all active branches, but I thought trunk is a good start. I can take a look and submit patches for other branches, that are active. But in the mean time this patch can go in as is into trunk. > mismatched CR/LF endings in text files > -------------------------------------- > > Key: ZOOKEEPER-1574 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1574 > Project: ZooKeeper > Issue Type: Bug > Reporter: Raja Aluri > Assignee: Raja Aluri > Attachments: ZOOKEEPER-1574.trunk.patch > > > Source code in zookeeper repo has a bunch of files that have CRLF endings. > With more development happening on windows there is a higher chance of more > CRLF files getting into the source tree. > I would like to avoid that by creating .gitattributes file which prevents > sources from having CRLF entries in text files. > But before adding the .gitattributes file we need to normalize the existing > tree, so that people when they sync after .giattributes change wont end up > with a bunch of modified files in their workspace. > I am adding a couple of links here to give more primer on what exactly is the > issue and how we are trying to fix it. > [http://git-scm.com/docs/gitattributes#_checking_out_and_checking_in] > [http://stackoverflow.com/questions/170961/whats-the-best-crlf-handling-strategy-with-git] > I will submit a separate bug and patch for .gitattributes -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira