[ https://issues.apache.org/jira/browse/ZOOKEEPER-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562133#comment-13562133 ]
Hadoop QA commented on ZOOKEEPER-1423: -------------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12566395/ZOOKEEPER-1423.2.patch against trunk revision 1437257. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1361//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1361//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1361//console This message is automatically generated. > 4lw and jmx should expose the size of the datadir/datalogdir > ------------------------------------------------------------ > > Key: ZOOKEEPER-1423 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1423 > Project: ZooKeeper > Issue Type: Improvement > Components: jmx > Reporter: Patrick Hunt > Assignee: Edward Ribeiro > Labels: newbie > Attachments: ZOOKEEPER-1423.2.patch, ZOOKEEPER-1423.patch > > > There are no metrics currently available on the size of the > datadir/datalogdir. These grow w/o bound unless the cleanup script is run. It > would be good to expose these metrics through jmx/4lw such that monitoring > can be done on the size. Would key ppl in on whether cleanup was actually > running. In particular this could be monitored/alerted on by third party > systems (nagios, ganglia and the like). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira