[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13565035#comment-13565035
 ] 

Marshall McMullen commented on ZOOKEEPER-1562:
----------------------------------------------

Deepak, Thanks for the patch. Have been meaning to get to this but way too much 
on my plate.

I reviewed the patch and it looks good to me. Pretty simple fix. I assume with 
this fix all the unit tests still pass and there is no longer a memory leak ?

If you verify those two things then +1 for me.
                
> Memory leaks in zoo_multi API
> -----------------------------
>
>                 Key: ZOOKEEPER-1562
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1562
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.4.3, 3.4.4
>         Environment: Zookeeper client and server both are running on CentOS 
> 6.3
>            Reporter: Deepak Jagtap
>            Assignee: Marshall McMullen
>            Priority: Trivial
>              Labels: patch
>             Fix For: 3.4.5
>
>         Attachments: ZOOKEEPER-1562.patch
>
>
> Valgrind is reporting memory leak for zoo_multi operations.
> ==4056== 2,240 (160 direct, 2,080 indirect) bytes in 1 blocks are definitely 
> lost in loss record 18 of 24
> ==4056==    at 0x4A04A28: calloc (vg_replace_malloc.c:467)
> ==4056==    by 0x504D822: create_completion_entry (zookeeper.c:2322)
> ==4056==    by 0x5052833: zoo_amulti (zookeeper.c:3141)
> ==4056==    by 0x5052A8B: zoo_multi (zookeeper.c:3240)
> It looks like completion entries for individual operations in multiupdate 
> transaction are not getting freed. My observation is that memory leak size 
> depends on the number of operations in single mutlipupdate transaction

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to