> On Jan. 31, 2013, 12:58 a.m., fpj wrote: > > /src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java, line > > 243 > > <https://reviews.apache.org/r/6707/diff/5/?file=251937#file251937line243> > > > > I guess that the problem of having the quorum verifier info into stat > > is that we would have to ship it with every response? I was really looking > > for a way of removing the reference to QuorumZooKeeperServer.
Just in responses for getData and reconfig, where you probably want to know anyway what happened. For example in incremental reconfig you just say the delta but don't know the final state. > On Jan. 31, 2013, 12:58 a.m., fpj wrote: > > /src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java, > > line 267 > > <https://reviews.apache.org/r/6707/diff/5/?file=251945#file251945line267> > > > > Could you explain me why you're shutting down leader election here? How > > can we get into this scenario? This is when during leader election you discover a server from a future configuration. For example the new configuration were activated while you were down. In this case you may be not talking to the right set of servers. We update the set of servers and restart leader election so that you connect to the right peers. The configuration info is now sent in all FLE notification messages for this purpose. In general, in several occasions (upon every "serious" change in configuration) I restart leader election. In many places this can be avoided, for example by connecting to new peers, or modifying existing connections. So restarting is often done for simplicity to reuse existing code. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6707/#review15907 ----------------------------------------------------------- On Jan. 25, 2013, 7:59 a.m., Alexander Shraer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6707/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2013, 7:59 a.m.) > > > Review request for zookeeper. > > > Description > ------- > > see https://issues.apache.org/jira/browse/ZOOKEEPER-107 > > > Diffs > ----- > > /src/c/include/proto.h 1438352 > /src/c/include/zookeeper.h 1438352 > /src/c/src/cli.c 1438352 > /src/c/src/zookeeper.c 1438352 > /src/java/main/org/apache/zookeeper/KeeperException.java 1438352 > /src/java/main/org/apache/zookeeper/ZooDefs.java 1438352 > /src/java/main/org/apache/zookeeper/ZooKeeper.java 1438352 > /src/java/main/org/apache/zookeeper/ZooKeeperMain.java 1438352 > /src/java/main/org/apache/zookeeper/cli/GetConfigCommand.java PRE-CREATION > /src/java/main/org/apache/zookeeper/cli/ReconfigCommand.java PRE-CREATION > /src/java/main/org/apache/zookeeper/common/StringUtils.java 1438352 > /src/java/main/org/apache/zookeeper/server/DataTree.java 1438352 > /src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java > 1438352 > /src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java > 1438348 > /src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java > 1438352 > /src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java > 1438352 > /src/java/main/org/apache/zookeeper/server/Request.java 1438352 > /src/java/main/org/apache/zookeeper/server/ServerCnxnFactory.java 1438352 > /src/java/main/org/apache/zookeeper/server/TraceFormatter.java 1438352 > /src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java > 1438352 > /src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java > 1438352 > /src/java/main/org/apache/zookeeper/server/quorum/Follower.java 1438352 > > /src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java > 1438352 > /src/java/main/org/apache/zookeeper/server/quorum/Leader.java 1438352 > /src/java/main/org/apache/zookeeper/server/quorum/Learner.java 1438352 > /src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java > 1438352 > /src/java/main/org/apache/zookeeper/server/quorum/Observer.java 1438352 > > /src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java > 1438352 > /src/java/main/org/apache/zookeeper/server/quorum/QuorumBean.java 1438352 > /src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java > 1438352 > /src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 1438352 > /src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java > 1438352 > /src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java > 1438352 > > /src/java/main/org/apache/zookeeper/server/quorum/QuorumZooKeeperServer.java > 1438352 > > /src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java > 1438352 > > /src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumHierarchical.java > 1438352 > /src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumMaj.java > 1438352 > > /src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumVerifier.java > 1438352 > /src/java/main/org/apache/zookeeper/server/util/ConfigUtils.java > PRE-CREATION > /src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java 1438352 > /src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java > 1438352 > /src/java/test/org/apache/zookeeper/server/quorum/ReconfigRecoveryTest.java > PRE-CREATION > /src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java 1438352 > /src/java/test/org/apache/zookeeper/test/CnxManagerTest.java 1438352 > > /src/java/test/org/apache/zookeeper/test/NIOConnectionFactoryFdLeakTest.java > 1438352 > /src/java/test/org/apache/zookeeper/test/QuorumMajorityTest.java > PRE-CREATION > /src/java/test/org/apache/zookeeper/test/QuorumUtil.java 1438352 > /src/java/test/org/apache/zookeeper/test/ReconfigTest.java PRE-CREATION > /src/zookeeper.jute 1438352 > > Diff: https://reviews.apache.org/r/6707/diff/ > > > Testing > ------- > > New test files were added: ReconfigTest, ReconfigRecoveryTest and > QuorumMajorityTest. Many other tests were modified. > > > Thanks, > > Alexander Shraer > >
