[ https://issues.apache.org/jira/browse/ZOOKEEPER-1679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13617733#comment-13617733 ]
Hadoop QA commented on ZOOKEEPER-1679: -------------------------------------- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12576154/ZOOKEEPER-1679.patch against trunk revision 1462141. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1441//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1441//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1441//console This message is automatically generated. > c client: use -Wdeclaration-after-statement > ------------------------------------------- > > Key: ZOOKEEPER-1679 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1679 > Project: ZooKeeper > Issue Type: Improvement > Components: c client > Affects Versions: 3.4.5 > Reporter: Michi Mutsuzaki > Assignee: Michi Mutsuzaki > Priority: Minor > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1679.patch > > > Visual studio still doesn't support c99. > --Michi -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira