[ https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13630868#comment-13630868 ]
Hadoop QA commented on ZOOKEEPER-1683: -------------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12578570/ZOOKEEPER-1683-ver2.patch against trunk revision 1463329. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1457//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1457//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1457//console This message is automatically generated. > ZooKeeper client NPE when updating server list on disconnected client > --------------------------------------------------------------------- > > Key: ZOOKEEPER-1683 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1683 > Project: ZooKeeper > Issue Type: Bug > Components: java client > Affects Versions: 3.5.0 > Reporter: Shevek > Assignee: Alexander Shraer > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1683.patch, ZOOKEEPER-1683-ver1.patch, > ZOOKEEPER-1683-ver2.patch > > > 2013-04-04 22:16:15,872 ERROR [pool-4-thread-1] > com.netflix.curator.ConnectionState.getZooKeeper (ConnectionState.java:84) - > Background exception caught > java.lang.NullPointerException > at > org.apache.zookeeper.client.StaticHostProvider.updateServerList(StaticHostProvider.java:161) > ~[zookeeper-3.5.0.jar:3.5.0--1] > at > org.apache.zookeeper.ZooKeeper.updateServerList(ZooKeeper.java:183) > ~[zookeeper-3.5.0.jar:3.5.0--1] > at > com.netflix.curator.HandleHolder$1$1.setConnectionString(HandleHolder.java:121) > ~[curator-client-1.3.5-SNAPSHOT.jar:?] > The duff code is this: > ClientCnxnSocket clientCnxnSocket = cnxn.sendThread.getClientCnxnSocket(); > InetSocketAddress currentHost = (InetSocketAddress) > clientCnxnSocket.getRemoteSocketAddress(); > boolean reconfigMode = hostProvider.updateServerList(serverAddresses, > currentHost); > Now, currentHost might be null, if we're not yet connected. But > StaticHostProvider.updateServerList indirects on it unconditionally. > This would be caught by findbugs. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira