[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13652661#comment-13652661
 ] 

Alexander Shraer commented on ZOOKEEPER-1701:
---------------------------------------------

I don't think that additional tests are needed since all we do here is avoid 
writing to disk when old and new versions are the same. The old (committed) 
version is already on disk, so no need to duplicate it.
                
> When new and old config have the same version, no need to write new config to 
> disk or create new connections
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1701
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1701
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: server
>    Affects Versions: 3.5.0
>            Reporter: Alexander Shraer
>            Assignee: Alexander Shraer
>            Priority: Minor
>             Fix For: 3.5.0
>
>         Attachments: ZOOKEEPER-1701.patch
>
>
> setLastSeenQuorumVerifier in QuorumPeer.java always writes the new config to 
> disk and tries to make new connections to servers in new config. When the new 
> config has the same version as the committed one (e.g., when the config 
> received in a NEWLEADER message is already known to the follower), there's no 
> need to write it to disk or to create new connections.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to