> On Aug. 20, 2013, 12:39 a.m., Edward Ribeiro wrote: > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/cli/ReconfigCommand.java, > > line 137 > > <https://reviews.apache.org/r/12983/diff/3/?file=342266#file342266line137> > > > > Please, remove those spaces (red bars) as much as possible. In this > > particular line, they were introduced.
I did not edit this line at all- I believe the whitespace existed before my changes. - Helen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12983/#review25329 ----------------------------------------------------------- On Aug. 19, 2013, 9:26 p.m., Helen Hastings wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12983/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2013, 9:26 p.m.) > > > Review request for zookeeper and Alexander Shraer. > > > Repository: zookeeper > > > Description > ------- > > Added standaloneEnabled flag to QuorumPeerConfig to give the option to > disable standalone mode for a single server. > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml > 1515597 > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/cli/ReconfigCommand.java > 1515597 > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java > 1515597 > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java > 1515597 > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/FollowerZooKeeperServer.java > 1515597 > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/LeaderZooKeeperServer.java > 1515597 > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java > 1515597 > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java > 1515597 > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java > 1515597 > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/StandaloneDisabledTest.java > PRE-CREATION > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ReconfigTest.java > 1515597 > > http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/test/StandaloneTest.java > 1515597 > > Diff: https://reviews.apache.org/r/12983/diff/ > > > Testing > ------- > > > Thanks, > > Helen Hastings > >
