[
https://issues.apache.org/jira/browse/ZOOKEEPER-1732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13781520#comment-13781520
]
Flavio Junqueira commented on ZOOKEEPER-1732:
---------------------------------------------
Thanks for working on this one, German. It is fine with me to have this one in
3.4.6, and here are some comments on the patch:
# This check is redundant, isn't it? I'd rather not have a redundant check. If
you have an idea for making the code clearer, then we could give a try, but
let's try to avoid redundant checks. Avoiding the additions to outofelection
won't make much difference in this case.
# I didn't understand why it is "newEpoch - 1" instead of "newEpoch" straight.
# The indentation doesn't seem right in Learner.java. I also suggest to add a
comment about updating the vote there, linking perhaps to this jira.
# What if we replace "updateElectionPeerEpoch" with either "updateElectionVote"
or "updateCurrentVote"? I also don't think it should be public.
# It would be simpler in updateElectionPeerEpoch() to have something like this:
{code}
setCurrentVote(new Vote(currentVote.getId(),
currentVote.getZxid(),
currentVote.getElectionEpoch(),
newEpoch-1,
currentVote.getState());
);
{code}
> ZooKeeper server unable to join established ensemble
> ----------------------------------------------------
>
> Key: ZOOKEEPER-1732
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1732
> Project: ZooKeeper
> Issue Type: Bug
> Components: leaderElection
> Affects Versions: 3.4.5
> Environment: Windows 7, Java 1.7
> Reporter: Germán Blanco
> Assignee: Germán Blanco
> Priority: Blocker
> Fix For: 3.5.0, 3.4.6
>
> Attachments: CREATE_INCONSISTENCIES_patch.txt, zklog.tar.gz,
> ZOOKEEPER-1732-3.4.patch, ZOOKEEPER-1732.patch
>
>
> I have a test in which I do a rolling restart of three ZooKeeper servers and
> it was failing from time to time.
> I ran the tests in a loop until the failure came out and it seems that at
> some point one of the servers is unable to join the enssemble formed by the
> other two.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
