[
https://issues.apache.org/jira/browse/ZOOKEEPER-1781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13789108#comment-13789108
]
Hudson commented on ZOOKEEPER-1781:
-----------------------------------
SUCCESS: Integrated in ZooKeeper-trunk #2082 (See
[https://builds.apache.org/job/ZooKeeper-trunk/2082/])
ZOOKEEPER-1781. ZooKeeper Server fails if snapCount is set to 1 (Takashi
Ohnishi via phunt, breed) (phunt:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1530110)
* /zookeeper/trunk/docs/index.pdf
* /zookeeper/trunk/docs/javaExample.pdf
* /zookeeper/trunk/docs/linkmap.pdf
* /zookeeper/trunk/docs/recipes.pdf
* /zookeeper/trunk/docs/releasenotes.pdf
* /zookeeper/trunk/docs/zookeeperAdmin.html
* /zookeeper/trunk/docs/zookeeperAdmin.pdf
* /zookeeper/trunk/docs/zookeeperHierarchicalQuorums.pdf
* /zookeeper/trunk/docs/zookeeperInternals.pdf
* /zookeeper/trunk/docs/zookeeperJMX.pdf
* /zookeeper/trunk/docs/zookeeperObservers.pdf
* /zookeeper/trunk/docs/zookeeperOver.pdf
* /zookeeper/trunk/docs/zookeeperProgrammers.pdf
* /zookeeper/trunk/docs/zookeeperQuotas.pdf
* /zookeeper/trunk/docs/zookeeperStarted.pdf
* /zookeeper/trunk/docs/zookeeperTutorial.pdf
ZOOKEEPER-1781. ZooKeeper Server fails if snapCount is set to 1 (Takashi
Ohnishi via phunt, breed) (phunt:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1530108)
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/docs/zookeeperAdmin.html
*
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
*
/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/InvalidSnapCountTest.java
> ZooKeeper Server fails if snapCount is set to 1
> ------------------------------------------------
>
> Key: ZOOKEEPER-1781
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1781
> Project: ZooKeeper
> Issue Type: Bug
> Components: quorum
> Affects Versions: 3.4.5
> Reporter: Takashi Ohnishi
> Assignee: Takashi Ohnishi
> Priority: Minor
> Fix For: 3.4.6, 3.5.0
>
> Attachments: ZOOKEEPER-1781.patch, ZOOKEEPER-1781.patch
>
>
> If snapCount is set to 1, ZooKeeper Server can start but it fails with the
> below error:
> 2013-10-02 18:09:07,600 [myid:1] - ERROR
> [SyncThread:1:SyncRequestProcessor@151] - Severe unrecoverable error, exiting
> java.lang.IllegalArgumentException: n must be positive
> at java.util.Random.nextInt(Random.java:300)
> at
> org.apache.zookeeper.server.SyncRequestProcessor.run(SyncRequestProcessor.java:93)
> In source code, it maybe be supposed that snapCount must be 2 or more:
> {code:title=org.apache.zookeeper.server.SyncRequestProcessor.java|borderStyle=solid}
> 91 // we do this in an attempt to ensure that not all ofthe
> servers
> 92 // in the ensemble take a snapshot at the same time
> 93 int randRoll = r.nextInt(snapCount/2);
> {code}
> I think this supposition is not bad because snapCount = 1 is not realistic
> setting...
> But, it may be better to mention this restriction in documentation or add a
> validation in the source code.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
