[
https://issues.apache.org/jira/browse/ZOOKEEPER-1785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13789911#comment-13789911
]
Hadoop QA commented on ZOOKEEPER-1785:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12607475/zkServersh.patch
against trunk revision 1530166.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1663//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1663//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1663//console
This message is automatically generated.
> Small fix in zkServer.sh to support new configuration format
> ------------------------------------------------------------
>
> Key: ZOOKEEPER-1785
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1785
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.5.0
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: zkServersh.patch
>
>
> The problem can be reproduced by running a server with the following type of
> config file:
> dataDir=/Users/shralex/zookeeper-test/zookeeper1
> syncLimit=2
> initLimit=5
> tickTime=2000
> server.1=localhost:2721:2731:participant;2791
> server.2=localhost:2722:2732:participant;2792
> and then trying to do "zkServer.sh status"
> Here I specified the servers using the new config format but still used the
> static config file and didn't include the "clientPort" key.
> zkServer.sh already supports the new configuration format, but expects server
> spec to appear in the dynamic config file if it uses the new format.
> So in the example above it will not find the client port.
> The current logic for executing something like 'zkServer.sh status' is:
> 1. Look for clientPort keyword in the static config file
> 2. Look for the client port in the server spec in the dynamic config file
> The attached patch adds an intermediate step:
> 1'. Look for the client port in the server spec in the static config file
--
This message was sent by Atlassian JIRA
(v6.1#6144)
