[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13804602#comment-13804602
 ] 

Germán Blanco commented on ZOOKEEPER-1742:
------------------------------------------

The test cases that fail in Linux must be related with the patch, since it is 
the only thing changed and the test cases passed without the patch. They don't 
look directly related with the changes, though. That is, at a first sight, they 
don't look like failures related with the counters that are updated in the 
functions that are wrapped. So it is probably some side effect, or an error in 
my changes.
My guess about the test cases that fail in Mac and don't fail in Linux is that 
they are related with the new environment. That could be libraries, compiler, 
operating system or any other part that is new; and it could be generic to all 
macos users or specific to the environment that I used (Mac OSX 10.8.5, gcc 
4.7.3). If anybody else has access to a mac, we can see if it fails in the same 
test cases or not, maybe that helps.

> "make check" doesn't work on macos
> ----------------------------------
>
>                 Key: ZOOKEEPER-1742
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1742
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Flavio Junqueira
>            Assignee: Benjamin Reed
>             Fix For: 3.4.6, 3.5.0
>
>         Attachments: ZOOKEEPER-1742-3.4.patch, ZOOKEEPER-1742.patch
>
>
> There are two problems I have spotted when running "make check" with the C 
> client. First, it complains that the sleep call is not defined in two test 
> files: tests/ZooKeeperQuorumServer.cc and tests/TestReconfigServer.cc. 
> Including unistd.h works. The second problem is with linker options. It 
> complains that "--wrap" is not a valid. I'm not sure how to deal with this 
> one yet, since I'm not sure why we are using it.  



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to