[ https://issues.apache.org/jira/browse/ZOOKEEPER-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13821163#comment-13821163 ]
Hadoop QA commented on ZOOKEEPER-1794: -------------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12613556/ZOOKEEPER-1794.patch against trunk revision 1540961. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1763//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1763//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1763//console This message is automatically generated. > Add hash check to transaction history in quorum servers > ------------------------------------------------------- > > Key: ZOOKEEPER-1794 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1794 > Project: ZooKeeper > Issue Type: Sub-task > Components: quorum > Affects Versions: 3.5.0 > Reporter: Germán Blanco > Assignee: Germán Blanco > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1794.patch, ZOOKEEPER-1794.patch > > Original Estimate: 336h > Remaining Estimate: 336h > > The goal of this task is to add a hash number to each transaction in the > transaction history. This hash number will depend on the entire transaction > history. This hash number will be the same in all members of the quorum, > since it shall have the same result if the members have the same transaction > history. That means that there will be no need to send any new information > between members of the quorum, during the broadcast phase. The hash number > will be checked by the leader when learners try to connect, and it shall also > be sent together with the snapshot during synchronisation. If the hash number > does not match, the synchronisation shall be done with a snapshot in order to > overwrite the conflicts in the transaction history. -- This message was sent by Atlassian JIRA (v6.1#6144)