[ https://issues.apache.org/jira/browse/ZOOKEEPER-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Germán Blanco updated ZOOKEEPER-1810: ------------------------------------- Attachment: ZOOKEEPER-1810.patch I think this covers the comments from [~rgs] and findbug warning issue. Regarding "isDebugEnabled", my understanding is that this is required for points in which there could be a drop in performance, but it doesn't make a big difference in other points. I have understood also that there is a preference for using "{}" in the logs instead of concatenating strings. > Add version to FLE notifications for trunk > ------------------------------------------ > > Key: ZOOKEEPER-1810 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1810 > Project: ZooKeeper > Issue Type: Sub-task > Affects Versions: 3.5.0 > Reporter: Flavio Junqueira > Assignee: Germán Blanco > Fix For: 3.5.0 > > Attachments: ZOOKEEPER-1810.patch, ZOOKEEPER-1810.patch, > ZOOKEEPER-1810.patch > > > The same as ZOOKEEPER-1808 but for trunk. -- This message was sent by Atlassian JIRA (v6.1#6144)