[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829232#comment-13829232
 ] 

Raul Gutierrez Segales commented on ZOOKEEPER-602:
--------------------------------------------------

Two nits:

{noformat}
+    class LearnerCnxAcceptor extends ZooKeeperThread{
{noformat}

space missing (ZooKeeperThread {)

Typo:
{noformat}
+            // When there is no worker thread pool, do the work directly 
+            // and waiting for its completion
{noformat}

"and wait for its completion"



> log all exceptions not caught by ZK threads
> -------------------------------------------
>
>                 Key: ZOOKEEPER-602
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-602
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: java client, server
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Rakesh R
>            Priority: Critical
>             Fix For: 3.4.6, 3.5.0
>
>         Attachments: ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, 
> ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, ZOOKEEPER-602.patch, 
> ZOOKEEPER-602.patch
>
>
> the java code should add a ThreadGroup exception handler that logs at ERROR 
> level any uncaught exceptions thrown by Thread run methods.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to