[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13838205#comment-13838205
 ] 

Raul Gutierrez Segales commented on ZOOKEEPER-1632:
---------------------------------------------------

Actually, the error checking in zoo_async doesn't return early on every case:

https://github.com/apache/zookeeper/blob/trunk/src/c/src/zookeeper.c#L3513

So you could get rc distinct from ZOK  but still adaptor_send_queue(zh, 0) 
could have been called. So we'll just have to leak in the case of an error it 
seems :(.

> fix memory leaks in cli_st 
> ---------------------------
>
>                 Key: ZOOKEEPER-1632
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1632
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: c client
>            Reporter: Colin Patrick McCabe
>            Assignee: Flavio Junqueira
>            Priority: Minor
>             Fix For: 3.4.6, 3.5.0
>
>         Attachments: ZOOKEEPER-1632-b3.4.patch, ZOOKEEPER-1632-trunk.patch, 
> ZOOKEEPER-1632.001.patch, ZOOKEEPER-1632.002.patch
>
>
> Fix two memory leaks revealed by running:
> {code}
> valgrind --leak-check=full ./.libs/cli_st 127.0.0.1:2182
> create /foo
> quit
> {code}



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to