[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13842171#comment-13842171
 ] 

Hudson commented on ZOOKEEPER-1459:
-----------------------------------

FAILURE: Integrated in ZooKeeper-trunk #2144 (See 
[https://builds.apache.org/job/ZooKeeper-trunk/2144/])
ZOOKEEPER-1459. Standalone ZooKeeperServer is not closing 
  the transaction log files on shutdown (Rakesh R via fpj) (fpj: 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1548825)
* /zookeeper/trunk/CHANGES.txt
* 
/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java
* 
/zookeeper/trunk/src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java


> Standalone ZooKeeperServer is not closing the transaction log files on 
> shutdown
> -------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1459
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1459
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.4.0
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>             Fix For: 3.4.6, 3.5.0
>
>         Attachments: ZOOKEEPER-1459-branch-3_4.patch, 
> ZOOKEEPER-1459-branch-3_4.patch, ZOOKEEPER-1459.patch, ZOOKEEPER-1459.patch, 
> ZOOKEEPER-1459.patch, ZOOKEEPER-1459.patch, ZOOKEEPER-1459.patch, 
> ZOOKEEPER-1459.patch, ZOOKEEPER-1459.patch, ZOOKEEPER-1459.patch
>
>
> When shutdown the standalone ZK server, its only clearing the zkdatabase and 
> not closing the transaction log streams. When tries to delete the temporary 
> files in unit tests on windows, its failing.
> ZooKeeperServer.java
> {noformat}
>         if (zkDb != null) {
>             zkDb.clear();
>         }
> {noformat}
> Suggestion to close the zkDb as follows, this inturn will take care 
> transaction logs:
> {noformat}
>         if (zkDb != null) {
>             zkDb.clear();
>             try {
>                 zkDb.close();
>             } catch (IOException ie) {
>                 LOG.warn("Error closing logs ", ie);
>             }
>         }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to