----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15753/#review30254 -----------------------------------------------------------
./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java <https://reviews.apache.org/r/15753/#comment57918> Please reindent this file. 4 spaces, not tabs. These indentation rules must be in the How To Contribute guidelines somewhere. ./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java <https://reviews.apache.org/r/15753/#comment57919> The comment is hard to understand ? ./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java <https://reviews.apache.org/r/15753/#comment57920> It seems to be possible to implement this with a Latch, instead of waiting in a loop. Could you please change it? In general this looks very good to me :-) - German Blanco On Dec. 12, 2013, 8:53 a.m., Daniel Peon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15753/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2013, 8:53 a.m.) > > > Review request for zookeeper, German Blanco and fpj. > > > Bugs: ZOOKEEPER-1814 > https://issues.apache.org/jira/browse/ZOOKEEPER-1814 > > > Repository: zookeeper > > > Description > ------- > > See Zookeeper-1814. > > > Diffs > ----- > > ./src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml 1550368 > ./src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java > 1550368 > ./src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java > 1550368 > > ./src/java/test/org/apache/zookeeper/test/FLEMaxIntervalNotificationTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/15753/diff/ > > > Testing > ------- > > New test case checking that the parameter maxNotificationInterval can be > configurable. > > The test case overwrites the receiveConnection method in QuorumCnxManager > class in order to avoid any answer to Fast Leader Election. Thus, FLE is > forced to retry increasing exponentially the notifications interval. This > interval is measured and the test case stops when 3 consecutive measures are > equal. The test case will be OK if the measure is the configured in the cfg > file. > > > File Attachments > ---------------- > > ZOOKEEPER-1814.patch > > https://reviews.apache.org/media/uploaded/files/2013/12/11/7e510364-6df3-486e-b338-3398960ba6b0__ZOOKEEPER-1814.patch > > > Thanks, > > Daniel Peon > >
