[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13848298#comment-13848298
 ] 

Michi Mutsuzaki commented on ZOOKEEPER-1839:
--------------------------------------------

Thanks for the patch Rakesh, it looks good to me. One minor nit about code 
formatting:

{noformat}
+                LOG.warn(
+                        "Ignoring exception closing cnxn sessionid 0x"
+                                + Long.toHexString(cnxn.getSessionId()), e);
{noformat}

could be:

{noformat}
+                LOG.warn("Ignoring exception closing cnxn sessionid 0x"
+                         + Long.toHexString(cnxn.getSessionId()), e);
{noformat}

Rakesh, where did you see this deadlock? Is this related to some of the windows 
test failures?

> Deadlock in NettyServerCnxn
> ---------------------------
>
>                 Key: ZOOKEEPER-1839
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1839
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 3.4.5
>            Reporter: Rakesh R
>            Assignee: Rakesh R
>            Priority: Critical
>             Fix For: 3.4.6
>
>         Attachments: ZOOKEEPER-1839.patch, zk_threaddump-cnxn-closure.txt
>
>
> Deadlock found during NettyServerCnxn closure. Please see the attached 
> threaddump.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Reply via email to