[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13851825#comment-13851825
 ] 

Germán Blanco commented on ZOOKEEPER-1849:
------------------------------------------

Now I see the problem. The thing is that there are spaces instead of tabs in 
the lines around the change ... how should we handle this?
- update the lines around the change (as far as I know it could be all lines in 
the file)?
- use the same indentation that the lines around, even if it doesn't follow the 
convention?
- or leave it as it is now?

> NioNettySuiteTest fails in windows build
> ----------------------------------------
>
>                 Key: ZOOKEEPER-1849
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1849
>             Project: ZooKeeper
>          Issue Type: Sub-task
>          Components: tests
>    Affects Versions: 3.4.5, 3.5.0
>            Reporter: Germán Blanco
>            Assignee: Germán Blanco
>            Priority: Blocker
>             Fix For: 3.4.6, 3.5.0
>
>         Attachments: ZOOKEEPER-1849.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Reply via email to