[
https://issues.apache.org/jira/browse/ZOOKEEPER-442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13858297#comment-13858297
]
Rakesh R commented on ZOOKEEPER-442:
------------------------------------
Thanks [~rgs] for the comments and your time. I've updated latest patch by
addressing these comments. Could you please have a look at it.
I've done the following changes in the patch:
# Modified ZKWatchManager#contains logic.
# Splitted the contains check & removal logic into separate methods for better
readability.
# Done removal of the watcher after getting the server response. In previous
patch it was removing and not sending to the server in few conditions. Now api
will do basic contains check and send the request to the server, then waiting
for the response. Upon receiving the response, it will go for watcher removal.
# Added one test case for chroot scenario
# Added few logs in the test cases, for marking the steps.
> need a way to remove watches that are no longer of interest
> -----------------------------------------------------------
>
> Key: ZOOKEEPER-442
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-442
> Project: ZooKeeper
> Issue Type: Sub-task
> Components: java client, server
> Reporter: Benjamin Reed
> Assignee: Rakesh R
> Priority: Critical
> Fix For: 3.5.0
>
> Attachments: Remove Watch API.pdf, ZOOKEEPER-442.patch,
> ZOOKEEPER-442.patch, ZOOKEEPER-442.patch, ZOOKEEPER-442.patch,
> ZOOKEEPER-442.patch, ZOOKEEPER-442.patch, ZOOKEEPER-442.patch,
> ZOOKEEPER-442.patch, ZOOKEEPER-442.patch, ZOOKEEPER-442.patch,
> ZOOKEEPER-442.patch
>
>
> currently the only way a watch cleared is to trigger it. we need a way to
> enumerate the outstanding watch objects, find watch events the objects are
> watching for, and remove interests in an event.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
