[
https://issues.apache.org/jira/browse/ZOOKEEPER-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13868884#comment-13868884
]
Hadoop QA commented on ZOOKEEPER-1860:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12622516/ZOOKEEPER-1860.patch
against trunk revision 1556976.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1876//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1876//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1876//console
This message is automatically generated.
> Async versions of reconfig don't actually throw KeeperException nor
> InterruptedException
> ----------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1860
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1860
> Project: ZooKeeper
> Issue Type: Bug
> Components: java client
> Affects Versions: 3.5.0
> Reporter: Raul Gutierrez Segales
> Assignee: Raul Gutierrez Segales
> Attachments: ZOOKEEPER-1860.patch
>
>
> This was caught by [~fournc], the async versions of reconfig in the Java
> client don't actually throw KeeperException nor InterruptedException. Since
> this is unreleased code (i.e.: for 3.5.0) I don't think there are issues with
> changing the API (that is, considering what exceptions are thrown part of the
> API).
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
