[
https://issues.apache.org/jira/browse/ZOOKEEPER-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13870003#comment-13870003
]
Michi Mutsuzaki commented on ZOOKEEPER-1861:
--------------------------------------------
Thank you for the patch Ted. Here are my comments:
- This patch only fixes the issue at line 210, but not the one at 307.
- There is a similar issue at 338, though this one is slightly more complicated
since it does more than putting something in a map inside the containsKey block.
> ConcurrentHashMap isn't used properly in QuorumCnxManager
> ---------------------------------------------------------
>
> Key: ZOOKEEPER-1861
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1861
> Project: ZooKeeper
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Priority: Minor
> Attachments: zookeeper-1861-v1.txt
>
>
> queueSendMap is a ConcurrentHashMap.
> At line 210:
> {code}
> if (!queueSendMap.containsKey(sid)) {
> queueSendMap.put(sid, new ArrayBlockingQueue<ByteBuffer>(
> SEND_CAPACITY));
> {code}
> By the time control enters if block, there may be another concurrent put with
> same sid to the ConcurrentHashMap.
> putIfAbsent() should be used.
> Similar issue occurs at line 307 as well.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
