[ 
https://issues.apache.org/jira/browse/BOOKKEEPER-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13872498#comment-13872498
 ] 

Sijie Guo commented on BOOKKEEPER-661:
--------------------------------------

{quote}
It would be better to modify registerBookie() to get check if the 
Stat.getEphemeralOwner == current zk session id. In this case, registerBookie 
can just return. I think this is safer.
{quote}

checking session id is the safer way. will do that.

{quote}
Do we need diskWritable() & diskJustWritable()? They seem to be handled the 
same.
{quote}

they are related to DiskWarnThreshold and DiskSpaceThreshold. we handle 
different action in gc. when disk is just writable, we need to force gc. 





> Turn readonly back to writable if spaces are reclaimed.
> -------------------------------------------------------
>
>                 Key: BOOKKEEPER-661
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-661
>             Project: Bookkeeper
>          Issue Type: Improvement
>          Components: bookkeeper-server
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>             Fix For: 4.3.0
>
>         Attachments: BOOKKEEPER-661.diff, BOOKKEEPER-661.diff, 
> BOOKKEEPER-661_662.diff
>
>
> should be able to turn a bookie from readonly back to writable if the spaces 
> are reclaimed.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to