[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13873232#comment-13873232
 ] 

Hadoop QA commented on ZOOKEEPER-1811:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12623339/ZOOKEEPER-1811.patch
  against trunk revision 1557875.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1889//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1889//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1889//console

This message is automatically generated.

> The ZooKeeperSaslClient service name principal is hardcoded to "zookeeper"
> --------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1811
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1811
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: java client
>    Affects Versions: 3.4.5
>            Reporter: Harsh J
>         Attachments: ZOOKEEPER-1811.patch
>
>
> The ClientCnxn class in ZK instantiates the ZooKeeperSaslClient with a 
> hardcoded service name of "zookeeper". This causes all apps to fail in 
> accessing ZK in a secure environment where the administrator has changed the 
> principal name ZooKeeper runs as.
> The service name should be configurable.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to