[ https://issues.apache.org/jira/browse/ZOOKEEPER-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13888007#comment-13888007 ]
Raul Gutierrez Segales commented on ZOOKEEPER-1872: --------------------------------------------------- thanks for the update [~rakeshr]. two last points with regard to the not null check in tearDown(): {noformat} + for (int i = 0; i < numServers; i++) { + // checks to avoid unexpected cases + if (servers.mt != null) { + if (i < servers.mt.length) { + servers.mt[i].shutdown(); + } + } + } {noformat} why can't servers.mt be checked before looping as well? Can it really change while we loop? It also sounds like using < servers.mt.length as the loop's ending condition would make things simpler. > QuorumPeer is not shutdown in few cases > --------------------------------------- > > Key: ZOOKEEPER-1872 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1872 > Project: ZooKeeper > Issue Type: Sub-task > Reporter: Rakesh R > Assignee: Rakesh R > Labels: test > Fix For: 3.4.6, 3.5.0 > > Attachments: ZOOKEEPER-1872.patch, ZOOKEEPER-1872.patch, > ZOOKEEPER-1872.patch, ZOOKEEPER-1872.patch, ZOOKEEPER-1872.patch, > ZOOKEEPER-1872.patch, ZOOKEEPER-1872_br3_4.patch > > > Few cases are leaving quorumpeer running after the test case execution. Needs > proper teardown for these. -- This message was sent by Atlassian JIRA (v6.1.5#6160)