[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911360#comment-13911360
 ] 

Rakesh R commented on ZOOKEEPER-1871:
-------------------------------------

Hi [~bwtakacy], Thanks for the patch. Few comments, please see

- Does it really required to introduce a new argument "-waitforconnection" for 
the connection stablishment. 
Instead can we think of reusing the "-timeout" option value and can wait till 
the session timeout for the connection establishment. I hope deafult value 
30seconds is large time, isn't it?

- In tests, please add message part, it will give some hint for others about 
the expectation.
{code}
Assert.assertTrue(end_time - start_time > wait_timeout); 
{code}

After attaching the patch, please do 'Submit Patch', this will trigger the 
regression and gets the QA report.


> Add an option to zkCli to wait for connection before executing commands
> -----------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-1871
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1871
>             Project: ZooKeeper
>          Issue Type: Improvement
>            Reporter: Vinayakumar B
>         Attachments: ZOOKEEPER-1871.patch
>
>
> Add an option to zkCli to wait for connection before executing any commands.
> This is helpful for the execution of inline commands.
> We are having some scripts to create/delete znodes through commandline. But 
> if getting the connection delays due to one of the node down, then command 
> will fail with connectionloss even though quorum is available.
> So I propose a commandline option (similar to -server and -timeout) 
> "-waitforconnection" to wait for the connection before executing any commands.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to