[
https://issues.apache.org/jira/browse/ZOOKEEPER-1887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13918359#comment-13918359
]
Raul Gutierrez Segales commented on ZOOKEEPER-1887:
---------------------------------------------------
Thanks for the review [~thawan].
bq. There is startServer() and stopserver() facility in TestClient.cc. I
wondering if you can use this to expand the test coverage for the feature
especially for local=true. Since you can remove the watch even if you are in
disconnected state
sure - I'll add that to the case in which I test local=true after calling
zk.close().
bq. In c-client a watch is represented by (watcher_fn, context) tuple or
watcher_object_t internally. To make the c-client has the equivalent
functionality with Java client, we have to actually remove a watch based on
(watcher_fn, context) tuple instead. What do you think?
yeah i think maybe both ways would be convenient? i.e. you can either remove
anything that matches a watcher_fn or a specific tuple (watcher_fn, context).
Not sure if we need to support both.
> C implementation of removeWatches
> ---------------------------------
>
> Key: ZOOKEEPER-1887
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1887
> Project: ZooKeeper
> Issue Type: New Feature
> Components: c client
> Reporter: Raul Gutierrez Segales
> Assignee: Raul Gutierrez Segales
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1887.patch, ZOOKEEPER-1887.patch
>
>
> This is equivalent for ZOOKEEPER-442's Java impl.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
