-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19459/
-----------------------------------------------------------

(Updated March 20, 2014, 6:31 p.m.)


Review request for zookeeper, fpj, michim, Raul Gutierrez Segales, and Camille 
Fournier.


Changes
-------

Thank you Edward for the reviews. New patch contains the following changes
1) modified unlock() by using releaseLock(dir). Used | operator, release lock 
of both the dirs irrespective of ioexceptions
2) modified few logs
3) added two more quorum tests


Bugs: ZOOKEEPER-1502
    https://issues.apache.org/jira/browse/ZOOKEEPER-1502


Repository: zookeeper


Description
-------

Prevent multiple ZooKeeper servers are using the same data directories at same 
time.
Here trying to address the case where one ZK server JVM is running, what if 
another server mistakenly configured the the same data dir and starts.


Diffs (updated)
-----

  ./src/java/main/org/apache/zookeeper/server/ZKDatabase.java 1579683 
  ./src/java/main/org/apache/zookeeper/server/ZooKeeperServerMain.java 1579683 
  ./src/java/main/org/apache/zookeeper/server/persistence/FileTxnSnapLog.java 
1579683 
  ./src/java/test/org/apache/zookeeper/server/ZooKeeperServerMainTest.java 
1579683 
  ./src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java 1579683 
  ./src/java/test/org/apache/zookeeper/test/QuorumTest.java 1579683 

Diff: https://reviews.apache.org/r/19459/diff/


Testing
-------

standalone tests included, quorum test case to be added.


Thanks,

Rakesh R

Reply via email to