----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19508/ -----------------------------------------------------------
(Updated March 26, 2014, 11:04 p.m.) Review request for zookeeper. Changes ------- Addressed Rakesh's comments. Repository: zookeeper Description ------- Add a method to get the hostname or the ip address of InetSocketAddress without performing a reverse DNS lookup. It's basically a substitute for java.net.InetSocketAddress#getHostString(), which is only available since java 7. Diffs (updated) ----- http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/common/HostNameUtils.java PRE-CREATION http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 1582109 http://svn.apache.org/repos/asf/zookeeper/trunk/src/java/test/org/apache/zookeeper/common/HostNameUtilsTest.java PRE-CREATION Diff: https://reviews.apache.org/r/19508/diff/ Testing ------- Added unit tests, and verified the patch fixes ObserverTest.testObserver. Thanks, michim
