[
https://issues.apache.org/jira/browse/ZOOKEEPER-1701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13955990#comment-13955990
]
Hadoop QA commented on ZOOKEEPER-1701:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12637966/ZOOKEEPER-1701.patch
against trunk revision 1583495.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2014//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2014//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2014//console
This message is automatically generated.
> When new and old config have the same version, no need to write new config to
> disk or create new connections
> ------------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1701
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1701
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.5.0
> Reporter: Alexander Shraer
> Assignee: Alexander Shraer
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1701.patch, ZOOKEEPER-1701.patch
>
>
> setLastSeenQuorumVerifier in QuorumPeer.java always writes the new config to
> disk and tries to make new connections to servers in new config. When the new
> config has the same version as the committed one (e.g., when the config
> received in a NEWLEADER message is already known to the follower), there's no
> need to write it to disk or to create new connections.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
